Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: serialization methods for LocalWhisperTranscriber #5648

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Aug 28, 2023

Related Issues

Proposed Changes:

  • Serialization methods for LocalWhisperTranscriber

How did you test it?

Notes for the reviewer

Checklist

@ZanSara ZanSara requested a review from a team as a code owner August 28, 2023 16:36
@ZanSara ZanSara requested review from bogdankostic and removed request for a team August 28, 2023 16:36
@ZanSara ZanSara added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Aug 28, 2023
@ZanSara ZanSara merged commit 7f20eaa into default-to-from-dict Aug 29, 2023
50 of 51 checks passed
@ZanSara ZanSara deleted the whisper-local-serialization branch August 29, 2023 12:42
ZanSara added a commit that referenced this pull request Aug 29, 2023
* add default_to_dict and default_from_dict placeholders to ease migration to canals 0.7.0

* canals==0.7.0

* whisper components

* add to_dict/from_dict stubs

* import serialization methods in init to hide canals imports

* reno

* export deserializationerror too

* Update haystack/preview/__init__.py

Co-authored-by: Silvano Cerza <[email protected]>

* serialization methods for LocalWhisperTranscriber (#5648)

* chore: serialization methods for `FileExtensionClassifier` (#5651)

* serialization methods for FileExtensionClassifier

* Update test_file_classifier.py

* chore: serialization methods for `SentenceTransformersDocumentEmbedder` (#5652)

* serialization methods for SentenceTransformersDocumentEmbedder

* fix device management

* serialization methods for SentenceTransformersTextEmbedder (#5653)

* serialization methods for TextFileToDocument (#5654)

* chore: serialization methods for `RemoteWhisperTranscriber` (#5650)

* serialization methods for RemoteWhisperTranscriber

* remove patches

* Add default to_dict and from_dict in document stores built with factory (#5674)

* fix tests (#5671)

* chore: simplify serialization methods for `MemoryDocumentStore` (#5667)

* simplify serialization for MemoryDocumentStore

* remove redundant tests

* pylint

* chore: serialization methods for `MemoryRetriever` (#5663)

* serialization method for MemoryRetriever

* more tests

* remove hash from default_document_store_to_dict

* remove diff in factory.py

* chore: serialization methods for `DocumentWriter` (#5661)

* serialization methods for DocumentWriter

* more tests

* use factory

* black

---------

Co-authored-by: Silvano Cerza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants