-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix typos discovered by codespell #5778
Conversation
I have some doubts about this. I like this cause typos might make it harder to search for some words. On the other hand I wouldn't want to start a war on which is the correct way of writing a word. e.g color or colour Another HUGE issue that I see is that this is focused on english only and doesn't understand the context nor whether it's actually trying to fix english or another language. See Not really sure whether to accept this or not to be fair. 😕 |
Pull Request Test Coverage Report for Build 6173376004
💛 - Coveralls |
Skipped over the German content and would be easy to add [tool.codespell]
ignore-words-list = "ans,astroid,nd,ned,nin,requeset,ue"
quiet-level = 3
skip = "./test/nodes/*,./test/others/*,./test/samples/*" |
From what I see here, except for the German words, everything it corrected in English is good and helpful, to be honest. |
Cool for me then. 👍 |
Approved 👍 |
pyproject.toml
Outdated
@@ -278,6 +278,10 @@ packages = [ | |||
line-length = 120 | |||
skip_magic_trailing_comma = true # For compatibility with pydoc>=4.6, check if still needed. | |||
|
|||
[tool.codespell] | |||
ignore-words-list = "ans,astroid,nd,ned,nin,requeset,ue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One lingering question... Was Requeset
misspelled on purpose to make the assertion fail?
haystack/test/document_stores/test_opensearch.py
Line 1253 in 7194343
assert "Too Many Requeset" in caplog.text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a typo copy and pasted, the actual log message is incorrect too.
"Failed to insert a batch of '%s' documents because of a 'Too Many Requeset' response. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed both.
Also, some release notes are needed before merging this, I believe: https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this in my opinion. I already marked the PR with the ignore-for-release-notes
label.
Linting is failing. Seems quite strange. 🤔 https://github.com/deepset-ai/haystack/actions/runs/6162226091/job/16723238817?pr=5778 I guess those changes have been done before introducing linting checks. We should fix them in a separate PR I think. On a side note I fixed the license compliance workflow so it won't show as failing in PRs from forks. See #5791. |
Lint failures are fixed in #5783 I will remove reno entry despite #5778 (comment) and
|
Merged in |
Let's goooo! 🚀 Thanks again! 🙏 |
Related Issues
Proposed Changes:
https://pypi.org/project/codespell
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.