-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use ruff in pre-commit to further limit code complexity #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:modeling
topic:pipeline
topic:tests
topic:dependencies
topic:build/distribution
topic:DX
Developer Experience
labels
Sep 12, 2023
Pull Request Test Coverage Report for Build 6172318878
💛 - Coveralls |
silvanocerza
requested review from
silvanocerza
and removed request for
bogdankostic
September 13, 2023 08:07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I would remove this, it doesn't affect the end user.
silvanocerza
added
the
ignore-for-release-notes
PRs with this flag won't be included in the release notes.
label
Sep 13, 2023
I merged in If it's all green after that I'll approve and merge. |
silvanocerza
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ignore-for-release-notes
PRs with this flag won't be included in the release notes.
topic:build/distribution
topic:dependencies
topic:DX
Developer Experience
topic:modeling
topic:pipeline
topic:tests
type:documentation
Improvements on the docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
linting.yml
workflow installing all Haystack dependencies even if not necessary #5782 talks about linting improvements that we would like to makeProposed Changes:
Add the
ruff
linter to pre-commit.Ruff supports over 600 lint rules and can be used to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing (in Rust) tens or hundreds of times faster than any individual tool.
ruff --format=github .
in a GitHub Action provides intuitive GitHub Annotations to contributors...Also, added
noqa
lint directives on our most complex functions to keep our limits low.How did you test it?
%
pre-commit run ruff --all-files
%
pre-commit run --all-files
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.