-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to node 7.2.1 #30
base: master
Are you sure you want to change the base?
Conversation
@@ -14,6 +14,7 @@ | |||
"devDependencies": { | |||
"assert": "1.1.1", | |||
"mocha": "1.18.2", | |||
"node-util": "0.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't see this used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/defunctzombie/node-url/pull/30/files#diff-1dd241c4cd3fd1dd89c570cee98b79ddR24 you might need to hit load diff
This should be considered wip until there's a babel ES5 build |
@defunctzombie I've come up with a slightly nicer way of doing it over at: https://github.com/graingert/browser-libs-node/blob/master/webpack.config.babel.js This automatically builds a browser safe url module. |
@graingert Does that mean this PR is ready for review or is not relevant? |
This PR is important because it contains two breaking changes that node v7.x introduced :
So thank you for this, @graingert! But I was wondering what still needs to be done to get this merged ? Can I help ? |
I second that. What is the hold up here and is there anything that can help it along? |
Fixes #24.