Delete never used cli.rb #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli.rb is loaded by pry at startup, looking for cli options to add to pry command options. This file is slowing down pry startup by 50%, even it's not used. It's ok to not exist, since pry checks it: https://github.com/pry/pry/blob/master/lib/pry/plugins.rb#L38
This was referenced Sep 26, 2015
|
Hi @neves. That file was added here by @lukebergen to fix a specific issue. Then @mvz confirmed that removing the file still reintroduces the bug here. So I'm guessing this won't be merged unless you prove that the bug does not happen any more. Feel free to reopen if you can do that. Regards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli.rb is loaded by pry at startup, looking for cli options to add to pry command options.
This file is slowing down pry startup by 50%, even it's not used.
It's ok to not exist, since pry checks it:
https://github.com/pry/pry/blob/master/lib/pry/plugins.rb#L38