New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete never used cli.rb #47

Closed

neves wants to merge 1 commit into kyrylo:master from neves:master

neves commented Sep 26, 2015

cli.rb is loaded by pry at startup, looking for cli options to add to pry command options.
This file is slowing pry startup by 50%, but it's never used.
It's ok to not exist, since pry checks it:
https://github.com/pry/pry/blob/master/lib/pry/plugins.rb#L38

The same was proposed to pry-byebug:
deivid-rodriguez/pry-byebug#76
and pry-rescue:
ConradIrwin/pry-rescue#91


          Delete never used cli.rb

cli.rb is loaded by pry at startup, looking for cli options to add to pry command options.
This file is slowing pry startup by 50%, but it's never used.
It's ok to not exist, since pry checks it:
https://github.com/pry/pry/blob/master/lib/pry/plugins.rb#L38

The same was proposed to pry-byebug:
deivid-rodriguez/pry-byebug#76
and pry-rescue:
ConradIrwin/pry-rescue#91

Owner

kyrylo commented Sep 26, 2015

For some reason this breaks the test suite.
It was added to integrate with pry-rescue better. See the description: b4a20d4

We can safely remove the file, if pry-rescue removes it as well.

kyrylo closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet