Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in HyperdriveLP.sol comment #423

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Fix typo in HyperdriveLP.sol comment #423

merged 7 commits into from
Jul 10, 2023

Conversation

ryangoree
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: beb2660 Previous: 271650c Deviation Status
addLiquidity: min 709 gas 709 gas 0% 🟰
addLiquidity: avg 46543 gas 45450 gas 2.4048% 🚨
addLiquidity: max 83440 gas 83400 gas 0.0480% 🚨
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23022 gas 23022 gas 0% 🟰
checkpoint: max 33418 gas 33418 gas 0% 🟰
closeLong: min 659 gas 659 gas 0% 🟰
closeLong: avg 46411 gas 46621 gas -0.4504%
closeLong: max 81804 gas 81764 gas 0.0489% 🚨
closeShort: min 616 gas 616 gas 0% 🟰
closeShort: avg 41627 gas 41352 gas 0.6650% 🚨
closeShort: max 81667 gas 81627 gas 0.0490% 🚨
initialize: min 529 gas 529 gas 0% 🟰
initialize: avg 139316 gas 139316 gas 0% 🟰
initialize: max 140816 gas 140816 gas 0% 🟰
openLong: min 661 gas 661 gas 0% 🟰
openLong: avg 116575 gas 116166 gas 0.3521% 🚨
openLong: max 175672 gas 175672 gas 0% 🟰
openShort: min 709 gas 709 gas 0% 🟰
openShort: avg 158878 gas 159418 gas -0.3387%
openShort: max 218571 gas 218571 gas 0% 🟰
removeLiquidity: min 569 gas 569 gas 0% 🟰
removeLiquidity: avg 60510 gas 59523 gas 1.6582% 🚨
removeLiquidity: max 116368 gas 116368 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

coveralls commented Jul 9, 2023

Coverage Status

coverage: 97.26% (-0.2%) from 97.489% when pulling beb2660 on ryan-typo into 271650c on main.

* "Added spaces after ///"

* Adding space after //

* Implementing SafeCast

* Adding test for toUint224

* Resolving comments

* removing toUint from TWAP

* prettier

---------

Co-authored-by: ControlCplusControlV <[email protected]>
@gtowle03 gtowle03 merged commit 3ccbe22 into main Jul 10, 2023
5 checks passed
@gtowle03 gtowle03 deleted the ryan-typo branch July 10, 2023 18:57
gtowle03 added a commit that referenced this pull request Jul 10, 2023
* Fix typo in HyperdriveLP.sol comment

* 2.4 Fix: Creating toUint224 function and implementing it (#418)

* "Added spaces after ///"

* Adding space after //

* Implementing SafeCast

* Adding test for toUint224

* Resolving comments

* removing toUint from TWAP

* prettier

---------

Co-authored-by: ControlCplusControlV <[email protected]>

* Fix typo in HyperdriveLP.sol comment

* Removing toUint224 functions (#436)

* Fix typo in HyperdriveLP.sol comment

---------

Co-authored-by: gtowle03 <[email protected]>
Co-authored-by: ControlCplusControlV <[email protected]>
Co-authored-by: George Towle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants