Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing toUint224 functions #436

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Removing toUint224 functions #436

merged 1 commit into from
Jul 10, 2023

Conversation

gtowle03
Copy link
Contributor

@gtowle03 gtowle03 commented Jul 10, 2023

Removing all toUint224 functions

@gtowle03 gtowle03 requested a review from jalextowle July 10, 2023 16:20
@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: e0c7ae9 Previous: bad3181 Deviation Status
addLiquidity: min 709 gas 709 gas 0% 🟰
addLiquidity: avg 46240 gas 46543 gas -0.6510%
addLiquidity: max 83440 gas 83440 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23022 gas 23022 gas 0% 🟰
checkpoint: max 33418 gas 33418 gas 0% 🟰
closeLong: min 659 gas 659 gas 0% 🟰
closeLong: avg 46625 gas 46413 gas 0.4568% 🚨
closeLong: max 81804 gas 81804 gas 0% 🟰
closeShort: min 616 gas 616 gas 0% 🟰
closeShort: avg 41192 gas 41833 gas -1.5323%
closeShort: max 81667 gas 81667 gas 0% 🟰
initialize: min 529 gas 529 gas 0% 🟰
initialize: avg 139316 gas 139316 gas 0% 🟰
initialize: max 140816 gas 140816 gas 0% 🟰
openLong: min 661 gas 661 gas 0% 🟰
openLong: avg 118621 gas 116123 gas 2.1512% 🚨
openLong: max 175672 gas 175672 gas 0% 🟰
openShort: min 709 gas 709 gas 0% 🟰
openShort: avg 155921 gas 159418 gas -2.1936%
openShort: max 218571 gas 218571 gas 0% 🟰
removeLiquidity: min 569 gas 569 gas 0% 🟰
removeLiquidity: avg 60432 gas 60208 gas 0.3720% 🚨
removeLiquidity: max 116368 gas 116368 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 97.26% (+0.2%) from 97.039% when pulling e0c7ae9 on gtowle/removing-224 into bad3181 on main.

@gtowle03 gtowle03 merged commit 985508f into main Jul 10, 2023
@gtowle03 gtowle03 deleted the gtowle/removing-224 branch July 10, 2023 18:16
gtowle03 added a commit that referenced this pull request Jul 10, 2023
* Fix typo in HyperdriveLP.sol comment

* 2.4 Fix: Creating toUint224 function and implementing it (#418)

* "Added spaces after ///"

* Adding space after //

* Implementing SafeCast

* Adding test for toUint224

* Resolving comments

* removing toUint from TWAP

* prettier

---------

Co-authored-by: ControlCplusControlV <[email protected]>

* Fix typo in HyperdriveLP.sol comment

* Removing toUint224 functions (#436)

* Fix typo in HyperdriveLP.sol comment

---------

Co-authored-by: gtowle03 <[email protected]>
Co-authored-by: ControlCplusControlV <[email protected]>
Co-authored-by: George Towle <[email protected]>
gtowle03 added a commit that referenced this pull request Jul 10, 2023
* Fix typo in HyperdriveLP.sol comment

* 2.4 Fix: Creating toUint224 function and implementing it (#418)

* "Added spaces after ///"

* Adding space after //

* Implementing SafeCast

* Adding test for toUint224

* Resolving comments

* removing toUint from TWAP

* prettier

---------

Co-authored-by: ControlCplusControlV <[email protected]>

* Fix typo in HyperdriveLP.sol comment

* Removing toUint224 functions (#436)

* Fix typo in HyperdriveLP.sol comment

---------

Co-authored-by: gtowle03 <[email protected]>
Co-authored-by: ControlCplusControlV <[email protected]>
Co-authored-by: George Towle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants