Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seq.sequenceResultM returns seq instead of list #159

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

TheAngryByrd
Copy link
Collaborator

Proposed Changes

Closes #158

Types of changes

What types of changes does your code introduce to MyLib.1?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Technically a breaking change but I'd wager people use it in a seq pipeline.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

@TheAngryByrd TheAngryByrd force-pushed the 158-seq-sequenceResultM-should-return-seq branch from e3a36ab to 425a337 Compare December 1, 2021 15:21
@TheAngryByrd TheAngryByrd merged commit 4576079 into master Dec 1, 2021
TheAngryByrd added a commit that referenced this pull request Dec 1, 2021
- [Seq.sequenceResultM returns seq instead of list](#159) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
TheAngryByrd added a commit that referenced this pull request Dec 1, 2021
- [Seq.sequenceResultM returns seq instead of list](#159) Credits [@TheAngryByrd](https://github.com/TheAngryByrd)
@aurecchia
Copy link

It didn't impact me, but wasn't this a breaking change? 🤔

@TheAngryByrd TheAngryByrd deleted the 158-seq-sequenceResultM-should-return-seq branch January 11, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seq.sequenceResultM returns a list instead of a seq
2 participants