Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp: quick fix symbol workspace imports consider import maps #13623

Closed
kitsonk opened this issue Feb 7, 2022 · 1 comment · Fixed by #19692
Closed

lsp: quick fix symbol workspace imports consider import maps #13623

kitsonk opened this issue Feb 7, 2022 · 1 comment · Fixed by #19692
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Feb 7, 2022

When choosing a quick fix for importing a workspace symbol, and an import map specifier can be applied, it is preferred.
@kitsonk kitsonk added feat new feature (which has been agreed to/accepted) lsp related to the language server labels Feb 7, 2022
@kitsonk kitsonk mentioned this issue Feb 7, 2022
Closed
@KnorpelSenf
Copy link
Contributor

KnorpelSenf commented Apr 1, 2022 •
edited
Loading

Ideally, both the full URL and the import via import map should be suggested. I would expect the import via import map to be higher in the list as I agree it is preferred.
Edit: I think this was already considered in #10951

@dsherret dsherret mentioned this issue Jul 3, 2023
Merged
dsherret added a commit that referenced this issue Jul 3, 2023
@dsherret
feat(lsp): support import maps in quick fix and auto-imports (#19692)
e8a866c 
Closes denoland/vscode_deno#849
Closes #15330
Closes #10951
Closes #13623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lsp): support import maps in quick fix and auto-imports dsherret/deno
2 participants
@kitsonk @KnorpelSenf