Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): support import maps in quick fix and auto-imports #19692

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat(lsp): support import maps in quick fix and auto-imports #19692

merged 1 commit into from
Jul 3, 2023
+449 −19

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 3, 2023

Closes denoland/vscode_deno#849
Closes #15330
Closes #10951
Closes #13623

@dsherret dsherret added this to the 1.35 milestone Jul 3, 2023
@dsherret dsherret requested a review from bartlomieju July 3, 2023 15:32
bartlomieju
bartlomieju approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fantastic fix 🚀

@dsherret dsherret merged commit e8a866c into denoland:main Jul 3, 2023
@dsherret dsherret deleted the feat_support_import_map_quick_fix_auto_imports branch July 3, 2023 18:09
@nayeemrmn nayeemrmn mentioned this pull request Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.35
2 participants
@dsherret @bartlomieju