Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/crypto): export spki for RSA #12114

Merged
merged 7 commits into from
Oct 6, 2021
Merged

feat(ext/crypto): export spki for RSA #12114

merged 7 commits into from
Oct 6, 2021

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 17, 2021 •
edited
Loading

Towards #11690

Note that we do not encode the algorithm identifier based on id-RSASSA-PSS and id-RSAES-OAEP. See #11880 (comment)

@littledivy littledivy mentioned this pull request Sep 17, 2021
Closed
@bartlomieju bartlomieju added this to the 1.15.0 milestone Sep 17, 2021
lucacasonato
lucacasonato approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@lucacasonato lucacasonato merged commit 3aa8591 into denoland:main Oct 6, 2021
@littledivy littledivy deleted the export_spki_rsa branch October 6, 2021 11:00
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Oct 10, 2021
@littledivy @bartlomieju
feat(ext/crypto): export spki for RSA (denoland#12114)
ae65f9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @lucacasonato @bartlomieju