tests: enable wpt for url #9046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not ready to merge, because the WPT server is not shut down correctly on test success or failure. Zombie processes stay running. |
28 tasks
|
The good news: it seems to work on all platforms. The bad news: the WPT tests take so long they time out on the windows-2019 buildbot... 60 seconds? More like 60 minutes. I've pushed a patch that disables the WPT tests on that buildbot. |
bnoordhuis
approved these changes
Jan 21, 2021
satyarohith
reviewed
Jan 24, 2021
|
@bnoordhuis PTAL again. I managed to enable the tests on Windows now. |
bnoordhuis
approved these changes
Jan 24, 2021
Closed
lucacasonato
added a commit
that referenced
this pull request
Jan 25, 2021
This reverts commit 66e99d3.
lucacasonato
added a commit
that referenced
this pull request
Jan 25, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables all suites testing "url" in WPT. Out of 1728 tests, 360 fail.
cc @nayeemrmn