Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): enable web platform timer tests #9047

Merged

Conversation

caspervonb
Copy link
Contributor

Part of #9001

@caspervonb caspervonb changed the title test(wpt): enable timer tests test(cli): enable web platform timer tests Jan 7, 2021
@caspervonb
Copy link
Contributor Author

caspervonb commented Jan 7, 2021

Unfortunately most of the interesting tests are in html documents, so without attempting to parse them out into bundles (would have to be opt-in of course) this is the best we can get.

@lucacasonato
Copy link
Member

Unfortunately most of the interesting tests are in html documents, so without attempting to parse them out into bundles (would have to be opt-in of course) this is the best we can get.

Can you try upstream this?

@caspervonb

This comment has been minimized.

@caspervonb caspervonb marked this pull request as draft January 8, 2021 06:06
@caspervonb caspervonb marked this pull request as ready for review January 9, 2021 05:30
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lucacasonato lucacasonato merged commit 6d7da63 into denoland:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants