Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards compatibility for node removed as part of a patch #3537

Closed
apettenati opened this issue Jul 11, 2022 · 3 comments · Fixed by #3538
Closed

Backwards compatibility for node removed as part of a patch #3537

apettenati opened this issue Jul 11, 2022 · 3 comments · Fixed by #3538
Labels
breaking change core Issues in the core code (lib/core) fix Bug fixes

Comments

@apettenati
Copy link

Product: axe-core
Expectation: run on older versions of node

Actual: requires node engine of >=12 with a only a patch change

Motivation: removing support for node versions prior to 12 should be a breaking change

image

This commit deployed in version 4.4.2 removed support for node versions under 12. This caused a breaking change.

axe-core version: 4.4.2

For Tooling issues:

  • Node version: 10
  • Platform: Liniux
@apettenati apettenati mentioned this issue Jul 11, 2022
Closed
@ljharb ljharb mentioned this issue Jul 11, 2022
Merged
@ljharb
Copy link
Contributor

ljharb commented Jul 11, 2022

This is definitely a violation of semver; all v4 versions must support node 4 and higher. Please revert and publish a v4.4.3, and feel free to publish a v5 that requires node 12 if needed.

cc @WilcoFiers

ljharb added a commit to jsx-eslint/eslint-plugin-jsx-a11y that referenced this issue Jul 11, 2022
@ljharb
[Deps] pin axe-core to v4.4.1, due to a breaking change in a patch
b78f19d 
See dequelabs/axe-core#3537. Fixes #872.
stephenmathieson added a commit that referenced this issue Jul 11, 2022
@stephenmathieson
fix: Continue supporting Node >=4
4a06692 
Closes #3537
@stephenmathieson stephenmathieson mentioned this issue Jul 11, 2022
Merged
WilcoFiers pushed a commit that referenced this issue Jul 12, 2022
@stephenmathieson
fix: Continue supporting Node >=4 (#3538)
3399e41 
Closes #3537
@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jul 12, 2022 •
edited
Loading

Thanks for bringing this up. We have definitely made a mistake there. I'll have the fix released this week.

We need v12 for development, but it's not necessary for import / use.

@WilcoFiers WilcoFiers reopened this Jul 12, 2022
@WilcoFiers WilcoFiers added core Issues in the core code (lib/core) breaking change fix Bug fixes labels Jul 12, 2022
@apettenati apettenati mentioned this issue Jul 12, 2022
Closed
straker pushed a commit that referenced this issue Jul 13, 2022
@stephenmathieson @straker
fix: Continue supporting Node >=4 (#3538)
a6c1cea 
Closes #3537
straker pushed a commit that referenced this issue Jul 13, 2022
@stephenmathieson @straker
fix: Continue supporting Node >=4 (#3538)
da7923b 
Closes #3537
@WilcoFiers
Copy link
Contributor

@apettenati @ljharb Axe-core 4.4.3 was released yesterday. This should be fixed. Apologies for the inconvenience.

ljharb added a commit to jsx-eslint/eslint-plugin-jsx-a11y that referenced this issue Jul 14, 2022
@ljharb
[Deps] unpin axe-core
2c6926c 
Fixed in dequelabs/axe-core#3537 (comment)
@WilcoFiers WilcoFiers mentioned this issue Dec 18, 2023
Closed
@Shubhabrata08 Shubhabrata08 mentioned this issue Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change core Issues in the core code (lib/core) fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Continue supporting Node >=4 dequelabs/axe-core
3 participants
@ljharb @WilcoFiers @apettenati