Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add ability to not manage yum repo file #153

Closed
voiprodrigo opened this issue Jun 24, 2020 · 6 comments
Closed

Feature request: add ability to not manage yum repo file #153

voiprodrigo opened this issue Jun 24, 2020 · 6 comments
Labels

Comments

@voiprodrigo
Copy link

Hi,

I need to use a custom internal repo. That repo is already setup by another module that is central to my infrastructure.
However, I don't see a way to make it so that the zookeeper module does not deploy a repo file (may be there though, if so appreciate a pointer)

Thanks!

@voiprodrigo
Copy link
Author

By the way, this is because at some point the default for $repo became 'cloudera' instead of undef. It was a very good default for my particular case.

@deric
Copy link
Owner

deric commented Jun 24, 2020

The possibility to configure custom repository was originally introduced in #40 with $repo set to undef. Having sane defaults is definitely a good idea. The change has been made in this commit as part of large refactoring #146. I'm sorry I didn't catch this.

@dhoppe is it ok to revert this change?

Pinpointing to specific release should be done for certain OS release, not globally.

@dhoppe
Copy link
Contributor

dhoppe commented Jul 3, 2020

@deric Sounds reasonable. I was not thinking about private repositories at all.

cegeka-jenkins pushed a commit to cegeka/puppet-zookeeper that referenced this issue Sep 7, 2020
@evgenkisel
Copy link

Hello! Where are you going to deliver fixes to disable the problem with setting up Cloudera repo by default?
Also I tried to change a value for the variable $repo in Hiera, but it doesn't work.

@MrMunki
Copy link

MrMunki commented Feb 11, 2021

It seems like the cloudera repo is not available, which causes the puppet run to fail any yum installs. I don't use the repo and download a custom version of zookeeper, is it possible to disable the repo all together? I had a look at the code and it seems that the "enabled => 1" option is hard coded on the custom repo, everything else is a variable, is it possible to set a variable on this too? That would work for the removal of the repo, just disable it.

@deric
Copy link
Owner

deric commented Mar 17, 2021

In v1.1.0 Cloudera repo is completely removed, $repo defaults to undef.

@deric deric closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants