fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…

…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.

master/pkg/tasks/dispatcher_task.go

@@ -786,12 +786,16 @@ func generateRunDeterminedLinkNames(
 				// Not the toplevel runDir, but is under it
 				if strings.HasPrefix(filePath, RunDir) && filePath != RunDir {
 					contained := strings.TrimPrefix(strings.TrimPrefix(filePath, RunDir), "/")
-					// If not a file, then extract the directory name
+					// If not a file, then extract the top-level directory name
 					if filepath.Base(contained) != contained {
 						dir, _ := filepath.Split(contained)
 						contained = filepath.Dir(dir)
 					}
-					linksSet[contained] = true
+					// links are only created for top-level directories under /run/determined
+					// If this is a file in a subdir, it will use the parent dir link
+					if !strings.Contains(contained, "/") {
+						linksSet[contained] = true
+					}
 				}
 			}
 		}

master/pkg/tasks/dispatcher_task_test.go

@@ -885,6 +885,9 @@ func Test_generateRunDeterminedLinkNames(t *testing.T) {
 				archive.Item{
 					Path: "/run/determined/xyz/abc.txt",
 				},
+				archive.Item{
+					Path: "/run/determined/xyz/subdir/abc.txt",
+				},
 			},
 		},
 	}