Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better logging for websocket failures [DET-3230] #709

Merged
merged 1 commit into from
Jun 12, 2020
Merged

chore: better logging for websocket failures [DET-3230] #709

merged 1 commit into from
Jun 12, 2020

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Jun 12, 2020 •
edited by jira bot
Loading

Description

The websocket library we use provides nice representations for events, example https://github.com/wildfoundry/dataplicity-lomond/blob/f7d0476c85777a4ce874323428a62ef085e76dd4/lomond/events.py#L130-L135 but we scrap that and just print the event name. To help trouble shooting issues, we should just print the entire event.

Test Plan

Before:

Failed to fetch command logs: WebSocket failure: rejected

After:

Failed to create command: WebSocket failure: Rejected(response=<response HTTP/1.0 400 Bad Request>, reason='Websocket upgrade failed (code=400)')

Commentary (optional)

@stoksc stoksc requested a review from dzhu June 12, 2020 16:59
@cla-bot cla-bot bot added the cla-signed label Jun 12, 2020
@stoksc stoksc changed the title chore: better loggin for websocket failures chore: better logging for websocket failures [DET-3230[ Jun 12, 2020
@stoksc stoksc changed the title chore: better logging for websocket failures [DET-3230[ chore: better logging for websocket failures [DET-3230] Jun 12, 2020
@dzhu dzhu assigned stoksc and unassigned dzhu Jun 12, 2020
@stoksc stoksc merged commit 63803a9 into determined-ai:master Jun 12, 2020
@stoksc stoksc deleted the better-ws-logging branch June 12, 2020 18:29
tayritenour pushed a commit to tayritenour/determined that referenced this pull request Apr 25, 2023
@jerryharrow @dzhu
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
92edc85 
…determined-ai#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
eecsliu pushed a commit to eecsliu/determined that referenced this pull request Jun 23, 2023
@jerryharrow @determined-ci
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
16b725b 
…determined-ai#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
stoksc pushed a commit that referenced this pull request Jun 26, 2023
@jerryharrow @hanyucui
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
2525c00 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
@jerryharrow @NicholasBlaskey
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
de3376c 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
@jerryharrow @stoksc
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
086d5cf 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
stoksc pushed a commit that referenced this pull request Jul 20, 2023
@jerryharrow @EmilyBonar
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
6d9553b 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
eecsliu pushed a commit that referenced this pull request Jul 24, 2023
@jerryharrow @eecsliu
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
c88eb73 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
stoksc pushed a commit that referenced this pull request Oct 17, 2023
@jerryharrow @NicholasBlaskey
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
ba33ca8 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
@jerryharrow @azhou-determined
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
bb6360a 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
@jerryharrow @determined-ci
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
164c6b9 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
@dannysauer dannysauer added this to the 0.12.10 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
@jerryharrow @djanicekpach
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
148fd9c 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
@jerryharrow @determined-ci
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
275cd5e 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
@jerryharrow @determined-ci
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
6bf46b9 
…#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
@jerryharrow @eecsliu
fix: Handle subdirs in expconf model_def with Launcher [FOUNDENG-479] (…
16d9c30 
…determined-ai#709)

If a model_def directory contained a subdir, it was incorrectly treated
as needing a softlink (but that is needed only for the top-level
child dirs of /run/determined) which causes a failure in the launcher
when trying to expand the archive.  Only convert top-level paths
under /run/determined to softlinks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhu dzhu dzhu approved these changes

Assignees

@stoksc stoksc

Labels
cla-signed
Projects
None yet
Milestone
0.12.10
Development

Successfully merging this pull request may close these issues.
3 participants
@stoksc @dzhu @dannysauer