Skip to content

Commit

Permalink
feat: set jupyter notebook file browser root to /. (#8678)
Browse files Browse the repository at this point in the history
  • Loading branch information
ioga authored and maxrussell committed Mar 21, 2024
1 parent e21e1bb commit 3f0b274
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
7 changes: 7 additions & 0 deletions docs/release-notes/jupyter-root.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
:orphan:

**Improvements**

- Notebooks: Jupyter notebook file browser (``ContentManager``) will no longer be locked down to
``work_dir``, and it'll have entire ``/`` filesystem visible. ``work_dir`` will stay the default
starting directory.
2 changes: 2 additions & 0 deletions master/static/srv/notebook-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,6 @@ jupyter lab --ServerApp.port=${NOTEBOOK_PORT} \
--LabServerApp.log_format="$JUPYTER_LAB_LOG_FORMAT" \
--LabApp.log_format="$JUPYTER_LAB_LOG_FORMAT" \
--ServerApp.log_format="$JUPYTER_LAB_LOG_FORMAT" \
--ServerApp.root_dir="/" \
--ContentsManager.preferred_dir="$PWD" \
2> >(tee -p >("$DET_PYTHON_EXECUTABLE" /run/determined/check_ready_logs.py --ready-regex "${READINESS_REGEX}") >&2)

0 comments on commit 3f0b274

Please sign in to comment.