Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set jupyter notebook file browser root to /. #8678

Merged
merged 1 commit into from
Jan 12, 2024
Merged

feat: set jupyter notebook file browser root to /. #8678

merged 1 commit into from
Jan 12, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Jan 11, 2024

Description

Set the root of the jupyter notebook file browser to /, and the default starting location to the work_dir.
Pros:

  • full file tree becomes visible
  • default starting directory in the file browser, launched notebooks or terminals stays the same (work_dir), unless you navigate away in the browser
  • you can always return back using the home icon, so it’s really hard to get lost
  • if you navigate somewhere you don’t have write permissions, creating new notebook will return a “permission denied” error. there’s no new permissions obtained by the user (as they could always reach whatever location outside the work_dir using the terminal).

Background: https://hpe-aiatscale.slack.com/archives/C02T7L0593K/p1704929788275849

Test Plan

  • Launch a notebook with or without work_dir config setting. Check if the default directories are still /run/determined/workdir, but you can access any directory you want (and have fs permissions to) from the file browser.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@ioga ioga requested a review from a team as a code owner January 11, 2024 18:56
@ioga ioga requested a review from salonig23 January 11, 2024 18:56
@cla-bot cla-bot bot added the cla-signed label Jan 11, 2024
Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 6cf9cb5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a039e009c43a0008b68e41
😎 Deploy Preview https://deploy-preview-8678--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@determined-ci determined-ci requested a review from a team January 11, 2024 18:56
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38e6825) 51.46% compared to head (6cf9cb5) 51.46%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8678   +/-   ##
=======================================
  Coverage   51.46%   51.46%           
=======================================
  Files         884      884           
  Lines      156121   156121           
  Branches     2088     2088           
=======================================
  Hits        80352    80352           
  Misses      74282    74282           
  Partials     1487     1487           
Flag Coverage Δ
backend 36.14% <ø> (ø)
harness 64.25% <ø> (ø)
web 53.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@ioga ioga merged commit 8671fbd into main Jan 12, 2024
85 of 96 checks passed
@ioga ioga deleted the jupyter-root branch January 12, 2024 16:53
@dannysauer dannysauer modified the milestone: 0.27.1 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants