Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ban archive columns in filter for experiment/search search #10172

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Oct 31, 2024

Ticket

ET-843

Description

This fixes an issue where the archived columns were available to filter on even though boolean columns aren't valid for searches. when used in a search, the search would fail with a 500 error.

Test Plan

when viewing the searches or experiments for a project, the user should not be able to see or select the "archived" column in the filter menu.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@ashtonG ashtonG requested a review from a team as a code owner October 31, 2024 17:48
@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
@ashtonG ashtonG requested review from keita-determined and removed request for julian-determined-ai October 31, 2024 17:48
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 3605142
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6723c2d79e563f000816609d
😎 Deploy Preview https://deploy-preview-10172--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.78%. Comparing base (9a30f26) to head (3605142).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10172      +/-   ##
==========================================
- Coverage   54.28%   50.78%   -3.50%     
==========================================
  Files        1259      953     -306     
  Lines      157285   130301   -26984     
  Branches     3642     3643       +1     
==========================================
- Hits        85379    66179   -19200     
+ Misses      71773    63989    -7784     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.30% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/Searches/Searches.tsx 61.70% <100.00%> (ø)
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 0.00% <0.00%> (ø)

... and 306 files with indirect coverage changes

@ashtonG ashtonG merged commit b4e7fa9 into main Oct 31, 2024
88 of 100 checks passed
@ashtonG ashtonG deleted the bug/ET-843/ban-archive-filter-for-experiments branch October 31, 2024 19:55
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants