fix: fix task openability check and a trial detail decoder mismatch [DET-3924 DET-3937] #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3d1b1a9.
|
how do we organize and name the fixtures? |
hamidzr
changed the title
hkang1
reviewed
Aug 24, 2020
| if (!isExperimentTask(task) && task.state in terminalCommandStates) return false; | ||
| if (isExperiment(task)) return true; | ||
| if (isExperimentTask(task)) return true; | ||
| if (terminalCommandStates.has(task.state)) return false; |
determined-dsw
pushed a commit
that referenced
this pull request
Aug 31, 2020
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
Bunify postgres_scim.go, remove references to HackAddUser, and add an intg test.
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
Bunify postgres_scim.go, remove references to HackAddUser, and add an intg test.
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
Bunify postgres_scim.go, remove references to HackAddUser, and add an intg test.
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
Bunify postgres_scim.go, remove references to HackAddUser, and add an intg test.
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
Bunify postgres_scim.go, remove references to HackAddUser, and add an intg test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
decoding issue: checkpoint resources can be null.
Test Plan
Commentary (optional)