fix: fix task openability check and a trial detail decoder mismatch [DET-3924 DET-3937]

webui/react/src/components/CheckpointModal.tsx

@@ -68,9 +68,11 @@ const CheckpointModal: React.FC<Props> = ({ config, checkpoint, onHide, show, ti
   }, [ checkpoint ]);
 
   const resources = useMemo(() => {
+    if (checkpoint.resources === undefined) return [];
+    const checkpointResources = checkpoint.resources;
     return Object.keys(checkpoint.resources)
-      .sort((a, b) => checkpoint.resources[a] - checkpoint.resources[b])
-      .map(key => ({ name: key, size: humanReadableBytes(checkpoint.resources[key]) }));
+      .sort((a, b) => checkpointResources[a] - checkpointResources[b])
+      .map(key => ({ name: key, size: humanReadableBytes(checkpointResources[key]) }));
   }, [ checkpoint.resources ]);
 
   return (

webui/react/src/fixtures/trialdetails-2994.json

@@ -0,0 +1,53 @@
+{
+  "end_time": "2020-08-20T00:16:46.465441+00:00",
+  "experiment_id": 1,
+  "hparams": {
+    "metrics_base": 0.9,
+    "metrics_sigma": 0,
+    "global_batch_size": 32,
+    "metrics_progression": "decreasing"
+  },
+  "id": 1,
+  "seed": 511579848,
+  "start_time": "2020-08-20T00:09:44.800485+00:00",
+  "state": "ERROR",
+  "warm_start_checkpoint_id": null,
+  "total_batches_processed": 100,
+  "steps": [
+    {
+      "id": 1,
+      "state": "COMPLETED",
+      "end_time": "2020-08-20T00:16:45.663342+00:00",
+      "checkpoint": {
+        "id": 1504,
+        "uuid": null,
+        "state": "ACTIVE",
+        "step_id": 1,
+        "end_time": null,
+        "metadata": {},
+        "trial_id": 1,
+        "resources": null,
+        "start_time": "2020-08-20T00:16:45.682217+00:00",
+        "validation_metric": 0.9
+      },
+      "start_time": "2020-08-20T00:16:38.35693+00:00",
+      "validation": {
+        "id": 2370,
+        "state": "COMPLETED",
+        "metrics": {
+          "num_inputs": 1024,
+          "validation_metrics": {
+            "validation_error": 0.9
+          }
+        },
+        "end_time": "2020-08-20T00:16:45.676929+00:00",
+        "start_time": "2020-08-20T00:16:45.666277+00:00"
+      },
+      "avg_metrics": {
+        "loss": 0.9000000000000005
+      },
+      "num_batches": 100,
+      "prior_batches_processed": 0
+    }
+  ]
+}

webui/react/src/ioTypes.ts

@@ -22,6 +22,7 @@ export const decode = <T>(type: io.Mixed, data: any): T => {
 };
 
 const ioNullOrUndefined = io.union([ io.null, io.undefined ]);
+const optional = (x: io.Mixed) => io.union([ x, ioNullOrUndefined ]);
 
 /* User */
 
@@ -161,7 +162,7 @@ const startEndTimeDef = {
 export const ioCheckpoint = io.type({
   ...startEndTimeDef,
   id: io.number,
-  resources: io.record(io.string, io.number),
+  resources: optional(io.record(io.string, io.number)),
   state: checkpointStatesIoType,
   step_id: io.number,
   trial_id: io.number,

webui/react/src/types.ts

@@ -234,7 +234,7 @@ export interface MetricName {
 // Checkpoint sub step.
 export interface Checkpoint extends StartEndTimes {
   id: number;
-  resources: Record<string, number>;
+  resources?: Record<string, number>;
   state: CheckpointState;
   stepId: number;
   trialId: number;

webui/react/src/utils/task.ts

@@ -5,8 +5,6 @@ import {
 } from 'types';
 import { terminalCommandStates } from 'utils/types';
 
-import { isExperiment } from './types';
-
 /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
 export function getRandomElementOfEnum(e: any): any {
   const keys = Object.keys(e);
@@ -116,8 +114,8 @@ export const isExperimentTask = (task: AnyTask): task is ExperimentTask => {
 };
 
 export const canBeOpened = (task: AnyTask): boolean => {
-  if (!isExperimentTask(task) && task.state in terminalCommandStates) return false;
-  if (isExperiment(task)) return true;
+  if (isExperimentTask(task)) return true;
+  if (terminalCommandStates.has(task.state)) return false;
   return !!task.url;
 };
 

webui/react/src/utils/types.ts

@@ -149,7 +149,7 @@ export function hasKey<O>(obj: O, key: keyof any): key is keyof O {
 
 // differentiate Experiment from Task
 export const isExperiment = (obj: AnyTask | Experiment): obj is Experiment => {
-  return 'config' in obj; // FIXME
+  return 'config' in obj && 'archived' in obj;
 };
 
 // used when properties are named differently between objects.
@@ -163,6 +163,7 @@ export const oneOfProperties = <T>(obj: any, props: string[]): T => {
 
 // size in bytes
 export const checkpointSize = (checkpoint: Checkpoint): number => {
+  if (!checkpoint.resources) return 0;
   const total = Object.values(checkpoint.resources).reduce((acc, size) => acc + size, 0);
   return total;
 };