fix: eagerly update experiments on successful write actions [DET-3263] #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
reviewed
Jun 8, 2020
hkang1
reviewed
Jun 8, 2020
| @@ -53,6 +53,9 @@ const TaskActionDropdown: React.FC<Props> = ({ task }: Props) => { | |||
| switch (params.key) { // Cases should match menu items. | |||
There was a problem hiding this comment.
nit: Not part of this PR, but up do you. Move // Cases should match menu items. to the line above?
There was a problem hiding this comment.
I prefer it here but the line above works too, it's closer to the target of the comment IMO
I move this section in #652 or and they'll collide if I change so slightly rather not change it here
hkang1
reviewed
Jun 8, 2020
hkang1
approved these changes
Jun 8, 2020
hamidzr
force-pushed
the
3263-local-update-experiments
branch
from
c531ef1
to
5c04f66
Compare
hamidzr
force-pushed
the
3263-local-update-experiments
branch
from
5c04f66
to
7f2aef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we locally update the experiment states on successful write actions to avoid waiting for the next poll period.
depends on #640
Test Plan
Commentary (optional)