-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tasks table component and task list page[DET-3221] #652
feat: add tasks table component and task list page[DET-3221] #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hamidzr This was probably not clearly outlined, but the tasks list page does not contain experiments and only commands (notebooks, tensorboards, shells and commands).
b5fc571
to
7a574d0
Compare
took out the experiments portion and rebased with master |
nit: Let's call it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table code looks really good. Surprisingly very short!
Storybook isn't working yet, probably still dependent on the storybook fix PR.
suggestions: Visual review
|
e3c3ef8
to
fe0d01a
Compare
thanks for the good suggestions! ✔️ * Add tooltip of the actual time for start time column.
a bit unsure about the last one 🤔 should we do the same for dashboard task cards? |
synced with @hamidzr will have a disabled/greyed out look for both dashboard and tasks table overflow when there are not actionable items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crossed the finish line!
Couple of minor things:
- using
useCallback
instead ofuseMemo
in that one area - removing duration for tasks table
#725 I set up a separate PR for adding the no action state to action drop down |
eh GitHub UI failed.. the test was passing the it showed as failing after merge 🤷♂️ |
Description
depends on #640 #636 #682
Test Plan
I suspect https://determinedai.atlassian.net/browse/DET-2982 is blocking the storybook added here from rendering.
Commentary (optional)
To keep the PR smaller planning to leave the following for future work: