Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove/archive trial collection code [WEB-938] [WEB-1289] #7297

Merged
merged 7 commits into from
Jul 11, 2023

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Jul 3, 2023

Description

Removes / archives a feature-flagged section in WebUI which we used to test out trial-level comparison.

Removing this section also allows us to remove:

  • LearningCurveChart (new version uses chart from UI Kit)
  • Table UI, types, and utilities only used in this part of WebUI
  • TrialCollection-exclusive API endpoints;
  • TrialCollection proto and bindings

Test Plan

App successfully builds, passes tests

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@mapmeld mapmeld requested a review from hkang1 July 3, 2023 21:30
@mapmeld mapmeld requested a review from a team as a code owner July 3, 2023 21:30
@mapmeld mapmeld requested review from corban-beaird and removed request for a team July 3, 2023 21:30
@cla-bot cla-bot bot added the cla-signed label Jul 3, 2023
@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 994d0a8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/64ad70dfbb8d3d0008c7ae8f
😎 Deploy Preview https://deploy-preview-7297--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, what a drop in lines! -14,827 :D

Couple of non-blocking comments, but was able to run test and build. The build seems to work as before.

webui/react/src/utils/set.ts Outdated Show resolved Hide resolved
webui/react/src/utils/string.ts Outdated Show resolved Hide resolved
@hkang1 hkang1 assigned mapmeld and unassigned hkang1 Jul 10, 2023
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go side lgtm

@mapmeld mapmeld enabled auto-merge (squash) July 11, 2023 15:22
@mapmeld mapmeld merged commit 881a6e8 into main Jul 11, 2023
@mapmeld mapmeld deleted the remove_trial_collections branch July 11, 2023 15:36
@dannysauer dannysauer added this to the 0.23.3 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants