Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused trials_augmented_view #8588

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

Description

#7297 removed the feature but not this database view or at least I think so it looks unused to me.

Views do have a development cost since they make changing the schema a lot more difficult.

Test Plan

CI passes

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 50e2521
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65943d33c741ad0008dbfab6

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) December 14, 2023 15:51
auto-merge was automatically disabled December 18, 2023 20:34

Pull Request is not mergeable

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) January 2, 2024 16:43
@NicholasBlaskey NicholasBlaskey merged commit 79df355 into main Jan 2, 2024
66 of 80 checks passed
@NicholasBlaskey NicholasBlaskey deleted the drop_aug_trials_view branch January 2, 2024 16:58
@dannysauer dannysauer added this to the 0.27.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants