Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support "formData" in swagger bindings parsing #8060

Closed
wants to merge 2 commits into from

Conversation

tayritenour
Copy link
Contributor

Description

We are using the swagger generation in lore, and need to support openapi.json that describe endpoints with formData as well. This doesn't change anything about the current bindings (which I ran with make -C proto build && make -C bindings build && make -C master build && make -C proto gen-buf-image)

Test Plan

Tests pass. Shouldn't need release party support

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 71e78f0
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/651dd9e8d7f4a10008a2db47

Copy link
Contributor

@szewaiyuen6 szewaiyuen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cla-bot
Copy link

cla-bot bot commented Oct 4, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Taylor Ritenour.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Oct 4, 2023
@tayritenour tayritenour force-pushed the enable_swagger_parse_form_data branch from 9041205 to 71e78f0 Compare October 4, 2023 21:32
@cla-bot
Copy link

cla-bot bot commented Oct 4, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Taylor Ritenour.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@tayritenour tayritenour closed this Oct 4, 2023
@tayritenour
Copy link
Contributor Author

Closed in favor of: #8078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants