-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support "formData" in swagger bindings parsing #8078
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What happen if we run this generation code on Lore, will there be no bindings created for the upload end point? Or the bindings would still be created but we just don't use it? |
When we run on Lore, it makes the bindings for all the objects and endpoints successfully. Before it was completely blocked from working so we need this allowance to do the build at all. The issue is that the generated endpoint for specifically anything that uses In the mean time, caleb is okay with just calling the particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks for the explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine!
Description
We are using the swagger generation in lore, and need to support openapi.json that describe endpoints with formData as well. This doesn't change anything about the current bindings (which I ran with make -C proto build && make -C bindings build && make -C master build && make -C proto gen-buf-image)
This is a workaround due to coupling with Lore. A proper fix ticket is here: https://hpe-aiatscale.atlassian.net/browse/MLG-1019
Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket