fix: Model delete redirect only needed if inside the model [WEB-1867] #8512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashtonG
reviewed
Nov 30, 2023
Comment on lines
152
to
157
| const listPath = useMemo( | ||
| () => | ||
| model.workspaceId ? paths.workspaceDetails(model.workspaceId, 'models') : paths.modelList(), | ||
| [model.workspaceId], | ||
| ); | ||
|
|
There was a problem hiding this comment.
nit: given that the model is already being passed into the modal component, and the path is only used when the modal is confirmed, can we move this into the deleteModelModal component?
There was a problem hiding this comment.
That makes sense; with the new commit I've changed the prop to redirectOnDelete and did the redirect path in the modal code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: deleting a model from a Workspace's Model Registry tab redirects us to the wrong place (general
/det/modelspage)Solution: a redirect is only needed if the user is requesting delete from the Model Details page, where I will pass a
listPathprop. Actions on the model registry tables will no longer trigger a redirect.Note: we don't use the store in models, so the registry takes a few seconds to update
Alternatives: I considered always passing a workspace to the delete modal, and redirecting by default. The issue was that ModelActionDropdown is wrapped by InteractiveTable/ContextMenu and cannot pass new props
Test Plan
Checklist
docs/release-notes/.See Release Note for details.