-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace useModal with updated Modal component [WEB-1828] [WEB-1891] #8578
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f4ba067
to
7a916b6
Compare
d13f070
to
b9c7850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b9c7850
to
43f3803
Compare
what do we expect to happen when this "New Model" button is pressed? |
43f3803
to
45a7bcf
Compare
ok I added some callbacks so the Checkpoint Flag -> Register Checkpoint -> New Model -> register to new model works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Use the updated Modal component ( determined-ai/hew#77 ) to replace Checkpoint and HyperparameterSearch modals
The HyperparameterSearch modal is easier; we just send a custom footer and update CSS.
Checkpoint modal has a few issues:
WEB-1891: hparam max slots can be 0 without flagging an error
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.