Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace useModal with updated Modal component [WEB-1828] [WEB-1891] #8578

Merged
merged 12 commits into from
Dec 19, 2023

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Dec 11, 2023

Description

Use the updated Modal component ( determined-ai/hew#77 ) to replace Checkpoint and HyperparameterSearch modals

The HyperparameterSearch modal is easier; we just send a custom footer and update CSS.

Checkpoint modal has a few issues:

  • in latest-main, creating a new model closes the previous form and doesn't register the MV to this new model, so it should be updated
  • in some locations the Modal is being redrawn when the table updates
  • the model fetch code is moved to the outside, but we would prefer it to be inside the modal code

WEB-1891: hparam max slots can be 0 without flagging an error

Test Plan

  • In an experiment, create a new hyperparameter search
  • In a completed experiment with checkpoints, register the checkpoint to a model

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Dec 11, 2023
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 45a7bcf
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6581f94bbf1d460008bdceb6
😎 Deploy Preview https://deploy-preview-8578--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mapmeld mapmeld force-pushed the dontUseModal branch 2 times, most recently from f4ba067 to 7a916b6 Compare December 13, 2023 18:51
@mapmeld mapmeld marked this pull request as ready for review December 13, 2023 18:52
@mapmeld mapmeld requested a review from a team as a code owner December 13, 2023 18:52
@mapmeld mapmeld requested review from hkang1 and julian-determined-ai and removed request for hkang1 December 13, 2023 18:52
@mapmeld mapmeld changed the title feat: Replace useModal with updated Modal component [WEB-1828] feat: Replace useModal with updated Modal component [WEB-1828] [WEB-1891] Dec 14, 2023
Copy link
Contributor

@julian-determined-ai julian-determined-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update the footer styling on the hyper parameter search modal so that it is more in line with our usual styling?

Screen Shot 2023-12-18 at 9 51 11 AM

@mapmeld
Copy link
Contributor Author

mapmeld commented Dec 18, 2023

Oh, that comes from the updates we made to the footer in Hew. Was able to remove some antd and CSS now that we can use the default Hew CSS.
Screen Shot 2023-12-18 at 11 26 01 AM

@julian-determined-ai
Copy link
Contributor

@mapmeld

what do we expect to happen when this "New Model" button is pressed?

BF68F6DD-CF09-4889-8DAB-96FE84A283D1_4_5005_c

@mapmeld
Copy link
Contributor Author

mapmeld commented Dec 19, 2023

ok I added some callbacks so the Checkpoint Flag -> Register Checkpoint -> New Model -> register to new model works

Copy link
Contributor

@julian-determined-ai julian-determined-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mapmeld mapmeld merged commit 27e3c1d into main Dec 19, 2023
70 of 81 checks passed
@mapmeld mapmeld deleted the dontUseModal branch December 19, 2023 21:00
@dannysauer dannysauer added this to the 0.27.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants