Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal props to replace useModal #77

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Add modal props to replace useModal #77

merged 5 commits into from
Dec 11, 2023

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Dec 11, 2023

  • Add custom footer prop and example
  • Reimplement ModalCloseReason
  • Modal returns close: (reason: ModalCloseReason) => void; to programmatically close a form (used in checkpointing to close one modal and open another)

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for hew-ui ready!

Name Link
🔨 Latest commit fb14381
🔍 Latest deploy log https://app.netlify.com/sites/hew-ui/deploys/657795a50ca07e00087a0332
😎 Deploy Preview https://deploy-preview-77--hew-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@determined-ci
Copy link
Collaborator

Hello! No changes detected to DesignKit for commit 34ae859. Verify here

@julian-determined-ai
Copy link
Contributor

@mapmeld just for visual styling I think it would be nice to have the footer background continue to have the same color as our other modals but I will leave that up to you.

@mapmeld
Copy link
Contributor Author

mapmeld commented Dec 11, 2023

Placed custom footer content inside of the <div className={css.footer}>...</div>, which changes the background and top-of-footer border

@mapmeld mapmeld merged commit 5188034 into main Dec 11, 2023
8 of 9 checks passed
@mapmeld mapmeld deleted the modal-extra branch December 11, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants