fix: fix fallback logic for partially provided custom logos #9842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
added
the
to-cherry-pick
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9842 +/- ##
=======================================
Coverage 54.71% 54.72%
=======================================
Files 1261 1261
Lines 156015 156011 -4
Branches 3590 3589 -1
=======================================
+ Hits 85361 85372 +11
+ Misses 70522 70507 -15
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hamidzr
force-pushed
the
hz-morelogodocs
branch
from
0e19b10
to
0701e5d
Compare
hamidzr
changed the title
hamidzr
force-pushed
the
hz-morelogodocs
branch
from
5768284
to
9a3a4dc
Compare
hamidzr
force-pushed
the
hz-morelogodocs
branch
from
9a3a4dc
to
5662c20
Compare
hamidzr
force-pushed
the
hz-morelogodocs
branch
from
f1da88c
to
0f9fe26
Compare
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| result := tt.variations.PickVariation(tt.mode, tt.orientation) | ||
| name := fmt.Sprintf("mode=%s, orientation=%s", tt.mode, tt.orientation) |
There was a problem hiding this comment.
If mode or orientation == "", then these test names might be a bit confusing.
Should we do
Suggested change
| name := fmt.Sprintf("mode=%s, orientation=%s", tt.mode, tt.orientation) | |
| mode := "none" | |
| if len(tt.mode) > 0 { | |
| mode = tt.mode | |
| } | |
| orientation := "none" | |
| if len(tt.orientation) > 0 { | |
| orientation = tt.orientation | |
| } | |
| name := fmt.Sprintf("mode=%s, orientation=%s", mode, orientation) |
There was a problem hiding this comment.
This is a nit, so feel free to ignore!
amandavialva01
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
we had a custom logic for doing fallback for variations of the logo that we needed from the user. here we simplify that and leave it to the user to decide to use duplicate vartions if desired.
Test Plan
logo_pathas well as one with some missing logo variationChecklist
docs/release-notes/See Release Note for details.