Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix fallback logic for partially provided custom logos #9842

Merged
merged 7 commits into from
Aug 21, 2024
Merged

fix: fix fallback logic for partially provided custom logos #9842

merged 7 commits into from
Aug 21, 2024

Commits on Aug 20, 2024

  1. docs: Add more details about logo path variations

    @hamidzr
    hamidzr committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b6a005a View commit details
    Browse the repository at this point in the history

  2. use backticks

    @hamidzr
    hamidzr committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3ddacd3 View commit details
    Browse the repository at this point in the history

  3. add failing tests for pickVariation

    @hamidzr
    hamidzr committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ed3e896 View commit details
    Browse the repository at this point in the history

  4. make it all required fields

    @hamidzr
    hamidzr committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    76051ff View commit details
    Browse the repository at this point in the history

  5. update docs

    @hamidzr
    hamidzr committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5662c20 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. simplify the test set up

    @hamidzr
    hamidzr committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4ed3ab5 View commit details
    Browse the repository at this point in the history

  2. rename logo_path to logo_paths

    @hamidzr
    hamidzr committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0f9fe26 View commit details
    Browse the repository at this point in the history