Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use cocoapod resource_bundles for PrivacyInfo #396

Closed
RayJiang16 opened this issue Mar 11, 2024 · 5 comments
Closed

Please use cocoapod resource_bundles for PrivacyInfo #396

RayJiang16 opened this issue Mar 11, 2024 · 5 comments

Comments

@RayJiang16
Copy link
Contributor

like sentry getsentry/sentry-cocoa#3651
otherwise we cannot build project

@baiyidjp
Copy link

How did you adapt this library? @RayJiang16

@RayJiang16
Copy link
Contributor Author

I added PrivacyInfo.xcprivacy to the main project.
This is a demo that cannot be build.
TestPrivacyInfo.zip

@li-jun
Copy link

li-jun commented Mar 20, 2024

please use

s.resource_bundles = {"DeviceKit" => ["Source/PrivacyInfo.xcprivacy"]}

instead of

s.resources                  = 'Source/PrivacyInfo.xcprivacy'

Otherwise, the PrivacyInfo file in the main project will be overwritten.

@anton-plebanovich
Copy link

anton-plebanovich commented Mar 27, 2024

Resolved in #397
I guess we may use fork repo as a workaround for now

  # TODO: Restore when the issue is resolved
  # https://github.com/devicekit/DeviceKit/issues/396
  # https://github.com/devicekit/DeviceKit/pull/397
  pod 'DeviceKit', :git => 'https://github.com/RayJiang16/DeviceKit', :commit => 'd0033296a30edfb294b78a64a26e708e8fff6339'

@Zandor300
Copy link
Member

Thanks @RayJiang16 for your fix. Merged and released just now in v5.2.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants