Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use cocoapod resource_bundles for PrivacyInfo #3651

Merged
merged 3 commits into from
Feb 19, 2024
Merged

fix: Use cocoapod resource_bundles for PrivacyInfo #3651

merged 3 commits into from
Feb 19, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Changed the inclusion of PrivacyInfo.xcprivacy to resource_bundles for cocoapod to avoid resource name collision when the user uses cocoapod as static library.

💡 Motivation and Context

Fixes getsentry/sentry-react-native#3599

💚 How did you test it?

Sample

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@brustolin brustolin mentioned this pull request Feb 19, 2024
Closed
11 tasks
philipphofmann
philipphofmann approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

philipphofmann
philipphofmann reviewed Feb 19, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@brustolin @philipphofmann
Update CHANGELOG.md
4ea12ff 
Co-authored-by: Philipp Hofmann <[email protected]>
@brustolin brustolin merged commit 3a2e953 into main Feb 19, 2024
24 checks passed
@brustolin brustolin deleted the fix/privacyinfo-cocoa branch February 19, 2024 12:17
@RayJiang16 RayJiang16 mentioned this pull request Mar 11, 2024
Closed
@michtntbrighte michtntbrighte mentioned this pull request Apr 3, 2024
Closed
11 tasks
airtelshivam pushed a commit to airtelshivam/sentry-cocoa that referenced this pull request Apr 12, 2024
@brustolin @airtelshivam
fix: Use cocoapod resource_bundles for PrivacyInfo (getsentry#3651)
025d6b6 
Changed the inclusion of PrivacyInfo.xcprivacy to resource_bundles for cocoapod to avoid resource name collision when the user uses cocoapod as static library.

Co-authored-by: Philipp Hofmann <[email protected]>
(cherry picked from commit 3a2e953)
@philips77 philips77 mentioned this pull request Apr 15, 2024
Closed
@robrechtme robrechtme mentioned this pull request Jul 1, 2024
Merged
@squio squio mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@armcknight armcknight Awaiting requested review from armcknight armcknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple commands produce PrivacyInfo.xcprivacy
2 participants
@brustolin @philipphofmann