Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use cocoapod resource_bundles for PrivacyInfo #397

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

RayJiang16
Copy link
Contributor

Changed the inclusion of PrivacyInfo.xcprivacy to resource_bundles for cocoapod to avoid resource name collision when the user uses cocoapod as static library.
#396

Copy link

@yan-zaitsev-hs yan-zaitsev-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had the same problem in our project.

@anton-plebanovich
Copy link

Please merge, the current setup of podspec is broken

@Zandor300 Zandor300 merged commit 81dd71a into devicekit:master Apr 15, 2024
13 of 15 checks passed
furiosFast added a commit to furiosFast/DeviceKit that referenced this pull request May 31, 2024
* master:
  Version bump. (v5.4.0)
  Add unknown orientation variant (devicekit#411)
  Version bump. (v5.3.1)
  Fix path for PrivacyInfo.xcprivacy in test target.
  Process Privacy manifest instead of copy on SPM. (devicekit#409)
  Version bump. (v5.3.0)
  Support for new May 2024 devices. (devicekit#412)
  Fix ruby version not found. (devicekit#414)
  Version bump. (v5.2.4)
  Enable MERGEABLE_LIBRARY. (devicekit#407)
  Update cocoapods to v1.15.2 in Gemfile.
  Release 5.2.3
  fix: Use cocoapod resource_bundles for PrivacyInfo (devicekit#397)
  Fix building for visionOS.  (devicekit#390)
  Fix building SwiftUI previews on macOS. (devicekit#389)
  Release 5.2.1 (devicekit#385)
  Fix PrivacyInfo.xcprivacy not being detected on SPM. (devicekit#384)
  Update swift-tools-version in Package.swift to 5.3 to support Resource files. (devicekit#381)

# Conflicts:
#	Source/Device.swift.gyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants