-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global macros clash with other things #530
Comments
glebm
added a commit
to glebm/libctru
that referenced
this issue
Sep 11, 2023
The prevents compatibility issues with other libraries, such as the one seen in devkitPro#530 Fixes devkitPro#530
glebm
added a commit
to glebm/libctru
that referenced
this issue
Sep 11, 2023
The prevents compatibility issues with other libraries, such as the one seen in devkitPro#530 Fixes devkitPro#530
glebm
added a commit
to glebm/libctru
that referenced
this issue
Sep 12, 2023
The mitigates compatibility issues with other libraries, such as the one seen in devkitPro#530. The `BIT` macro is kept because it is commonly used, so removing it would be too breaking of a change (see devkitPro#531 (comment)) Fixes devkitPro#530
glebm
added a commit
to glebm/libctru
that referenced
this issue
Sep 12, 2023
The mitigates compatibility issues with other libraries, such as the one seen in devkitPro#530. The `BIT` macro is kept because it is commonly used, so renaming it would be too breaking of a change (see devkitPro#531 (comment)) Fixes devkitPro#530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here, libctru defines some macros that can clash with other things:
libctru/libctru/include/3ds/types.h
Lines 51 to 52 in a4634c0
For example, with the latest version of libfmt, this does not work:
This is because libfmt uses
PACKED
as a template parameter name in one of its functions:https://github.com/fmtlib/fmt/blob/d4987546a4269cc21565ea633eed56db09039d1a/include/fmt/core.h#L1557-L1558
Including things in the opposite order works but really 3ds should not define such macros publicly:
This can be tricky to work around in a medium size codebase, e.g. diasurgical/devilutionX#6585
The text was updated successfully, but these errors were encountered: