Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTR_ prefix to ALIGN,PACKED,DEPRECATED macros #532

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

glebm
Copy link
Contributor

@glebm glebm commented Sep 12, 2023

The mitigates compatibility issues with other libraries, such as the one seen in #530.

The BIT macro is kept because it is commonly used, so renaming it would be too breaking of a change (see
#531 (comment))

Fixes #530

The mitigates compatibility issues with other libraries, such as the one seen in devkitPro#530.

The `BIT` macro is kept because it is commonly used, so renaming it
would be too breaking of a change (see
devkitPro#531 (comment))

Fixes devkitPro#530
@WinterMute
Copy link
Member

We're leaning towards possibly CTR_ rather than LIBCTRU_

Any opinions?

@fincs
Copy link
Member

fincs commented Oct 11, 2023

If the prefix introduced here is renamed to CTR_, I'd say this PR can be merged.

@fincs fincs changed the title Prefix macros: LIBCTRU_{ALIGN,PACKED,DEPRECATED} Add CTR_ prefix to ALIGN,PACKED,DEPRECATED macros Oct 11, 2023
@fincs fincs merged commit 41e31d3 into devkitPro:master Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global macros clash with other things
3 participants