Add option to always display connector selection even if there's only one #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution 🎉 |
|
https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest I'm not sure |
|
@MarcDufresne Ah, I see. Yeah, indeed; but thanks a lot for checking. ✔️ |
srenatus
reviewed
Aug 5, 2019
|
Test added! |
MarcDufresne
force-pushed
the
show-login-page
branch
from
8b7c074
to
0dbb642
Compare
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Add option to always display connector selection even if there's only one
maxlegault
added a commit
to maxlegault/charts
that referenced
this pull request
Sep 3, 2019
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
maxlegault
added a commit
to maxlegault/charts
that referenced
this pull request
Sep 3, 2019
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
maxlegault
added a commit
to maxlegault/charts
that referenced
this pull request
Sep 3, 2019
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
4 tasks
k8s-ci-robot
pushed a commit
to helm/charts
that referenced
this pull request
Sep 4, 2019
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
kengou
pushed a commit
to kengou/charts
that referenced
this pull request
Sep 18, 2019
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
ramkumarvs
pushed a commit
to yugabyte/charts-helm-fork
that referenced
this pull request
Sep 30, 2019
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently building an auth proxy system that will be used to authenticate users before being redirected to their destination. The fact that Dex automatically forwards to the connector if there's only one has been confusing for our users. They type
my-service.comin their browsers and end up on Google login, not a great UX.This PR allows to specify an option to always show the connector selection screen even if there's only one. That way our users will land on a themed login page, and select "Login with Google" before ending up on Google login.
Let me know what you think!