-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/dex] Add support to always display login screen #16806
Conversation
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
Hi @bernyfox. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bernyfox, vi7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
The current indentation of the OAuth2 configuration block doesn't allow for extra properties to be added. This allows to enable the new configuration that will always display the login screen, even though only one connector is defined. The default value (disabled) is also added to the values file for documentation. See also: https://github.com/dexidp/dex/releases/tag/v2.18.0 See also: dexidp/dex#1505 Signed-off-by: Maxime Legault-Venne <[email protected]>
What this PR does / why we need it:
The current indentation of the OAuth2 configuration block doesn't allow
for extra properties to be added. This allows to enable the new
configuration that will always display the login screen, even though
only one connector is defined.
The default value (disabled) is also added to the values file for
documentation.
See also: https://github.com/dexidp/dex/releases/tag/v2.18.0
See also: dexidp/dex#1505
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
)