-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve height target calculation for watchdog canister #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dragoljub-duric
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes calculation of height target for watchdog canister more strict.
min_explorers
).min_explorers
) are within a defined range of the median.Configs (currently in prod):
mainnet
-- explorers 6, min_explorers 3, blocks range [-2, 2]testnet
-- explorers 3, min_explorers 2, blocks range [-1000, 1000]Making the height target calculation more strict for the
testnet
is necessary because thetestnet
has fewer explorers and greater instability, leading to large block height divergences. A stricter calculation helps reduce noise and false positives by ensuring only explorers with closely aligned heights are considered valid, improving accuracy and stability.Mainnet explorers:
Testnet explorers: