Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable tracking api.bitaps.com testnet explorer in watchdog canister #328

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Sep 23, 2024

This PR re-enables the api.bitaps.com explorer for the testnet.

It was previously disabled due to instability, but with the stricter height target calculation introduced in PR327, this should improve the stability of testnet alerts.

@maksymar maksymar marked this pull request as ready for review September 23, 2024 11:24
@maksymar maksymar requested a review from a team as a code owner September 23, 2024 11:24
Copy link

github-actions bot commented Sep 23, 2024

canbench 🏋 (dir: .)

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.73 M (-0.01%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.01 M (0.01%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (0.02%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: pre_upgrade_with_many_unstable_blocks
  total:
    instructions: 5.82 B (0.21%) (change within noise threshold)
    heap_increase: 4097 pages (no change)
    stable_memory_increase: 1792 pages (no change)

  serialize_blocktree (scope):
    instructions: 2.39 B (0.45%) (change within noise threshold)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_flatten (scope):
    instructions: 201.60 K (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_serialize_seq (scope):
    instructions: 2.39 B (0.45%) (change within noise threshold)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@maksymar maksymar changed the title feat: re-enable api.bitaps.com testnet explorer feat: re-enable tracking api.bitaps.com testnet explorer in watchdog canister Sep 23, 2024
@maksymar maksymar enabled auto-merge (squash) September 23, 2024 18:47
@maksymar maksymar merged commit fcb41ac into master Sep 23, 2024
27 checks passed
@maksymar maksymar deleted the maksym/api-bitaps-com-testnet branch September 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants