feat: Reduce DTS slice limit for regular messages on system subnets #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we doing this now despite delaying changing the checkpoint interval on the NNS subnet until after the scheduled II subnet recovery? |
|
@schneiderstefan Yes, if you notice, I'm only changing the slice limit for regular messages. Given a 2B slice limit and the 50B total limit, we would have at most 25 slices. That's still quite fine even with a 200 rounds checkpoint interval. Increasing the checkpoint interval blocks decreasing the slice limit for |
dsarlis
changed the title
|
Marked as |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…lts set at system level) (#650) Deterministic Time Slicing, which allows large messages to execute across multiple rounds, was being tested in advance of releasing it as system settings. Now that t[he system settings are being updated](#621), we no longer need special configuration to test this on system subnets.
Tests were successful. |
dsarlis
changed the title
schneiderstefan
approved these changes
Jul 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Disable DTS in `drun` for system subnets to enable deterministic debug output testing. **Background information**: DTS aborts uncompleted messsages if they reach a checkpoint and retries them later. However, debug prints of such DTS-aborted executions leak, which leads to non-deterministic debug outputs and can disturb testing with `drun`. Therefore, disable DTS on system subnets in `drun` for deterministic debug outputs as required by Motoko's tests. This testing issue has become noticeable with #621.
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…lts set at system level) (dfinity#650) Deterministic Time Slicing, which allows large messages to execute across multiple rounds, was being tested in advance of releasing it as system settings. Now that t[he system settings are being updated](dfinity#621), we no longer need special configuration to test this on system subnets.
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…finity#621) This is a follow-up change to further decrease the DTS slice limit on system subnets for regular messages. The value is set to 2B instructions to match the setting on application subnets. `install_code` messages still use the bigger slice limit until the checkpoint interval is adjusted and we can afford reducing that as well. This will change in a future PR.
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
Disable DTS in `drun` for system subnets to enable deterministic debug output testing. **Background information**: DTS aborts uncompleted messsages if they reach a checkpoint and retries them later. However, debug prints of such DTS-aborted executions leak, which leads to non-deterministic debug outputs and can disturb testing with `drun`. Therefore, disable DTS on system subnets in `drun` for deterministic debug outputs as required by Motoko's tests. This testing issue has become noticeable with dfinity#621.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up change to further decrease the DTS slice limit on system subnets for regular messages. The value is set to 2B instructions to match the setting on application subnets.
install_codemessages still use the bigger slice limit until the checkpoint interval is adjusted and we can afford reducing that as well. This will change in a future PR.