chore(drun): Disable DTS for deterministic debug outputs #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, Gabor! |
mergify bot
pushed a commit
to dfinity/motoko
that referenced
this pull request
Sep 9, 2024
Using IC 2024-08-16 with some adjustments: * `drun` adjustments for better testing - dfinity/ic#662 (Lift 8GB memory boundary from drun) - dfinity/ic#988 (Enable Wasm64 with 16GB main memory capacity) - dfinity/ic#991 (Disable DTS for deterministic debug outputs) - dfinity/ic#992 (Increase batch limit for longer running tests) - dfinity/ic#1240 (Enable canister snapshots) * IC build fixes for `nix`: - Remove duplicate entries of same crate with same versions in `Cargo.toml`. - dfinity/ic#993 (Fix MacOS `rocksdb` dependency). * Other IC fixes: - dfinity/ic#1250 (Fix canister snapshots)
crusso
approved these changes
Sep 10, 2024
crusso
approved these changes
Sep 10, 2024
|
Just checked: The output of DTS-aborted messages are not written to the log. So, just a local testing phenomenon. |
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
Disable DTS in `drun` for system subnets to enable deterministic debug output testing. **Background information**: DTS aborts uncompleted messsages if they reach a checkpoint and retries them later. However, debug prints of such DTS-aborted executions leak, which leads to non-deterministic debug outputs and can disturb testing with `drun`. Therefore, disable DTS on system subnets in `drun` for deterministic debug outputs as required by Motoko's tests. This testing issue has become noticeable with dfinity#621.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable DTS in
drunfor system subnets to enable deterministic debug output testing.Background information:
DTS aborts uncompleted messsages if they reach a checkpoint and retries them later. However, debug prints of such DTS-aborted executions leak, which leads to non-deterministic debug outputs and can disturb testing with
drun. Therefore, disable DTS on system subnets indrunfor deterministic debug outputs as required by Motoko's tests.This testing issue has become noticeable with #621.