Skip to content

Commit

Permalink
fix: non-local import in Trie.mo (#495)
Browse files Browse the repository at this point in the history
Fixes a reference to `"mo:base/Debug"` in `Trie.mo` (originating from a PR in November), which appears to break `vessel verify` as mentioned in [this forum topic](https://forum.dfinity.org/t/heartbeat-improvements-timers-community-consideration/14201/94) and indicated by [this PR's CI output](https://github.com/dfinity/vessel-package-set/actions/runs/3797230768/jobs/6457979836). 

This also appears to affect `moc 0.7.4`, so we should definitely find a way to automatically screen for future regressions like this.

Co-authored-by: Ryan Vandersmith <[email protected]>
  • Loading branch information
ggreif and rvanasa committed Jan 5, 2023
1 parent b4b6cac commit a591019
Show file tree
Hide file tree
Showing 7 changed files with 423 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 16
- run: npm ci
- name: "initial checks"
run: npm test
- name: Check if Git tag exists
run: echo "name=HEAD_TAG::$(git tag --points-at HEAD)" >> $GITHUB_ENV
- uses: cachix/install-nix-action@v16
Expand Down
11 changes: 9 additions & 2 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
{
"semi": false,
"trailingComma": "none"
"overrides": [
{
"files": "*.mo",
"options": {
"semi": false,
"trailingComma": "none"
}
}
]
}
Loading

0 comments on commit a591019

Please sign in to comment.