fix: non-local import in Trie.mo
#495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ryan Vandersmith <[email protected]>
Add `Array.size`
ggreif
added a commit
that referenced
this pull request
Jan 5, 2023
Fixes a reference to `"mo:base/Debug"` in `Trie.mo` (originating from a PR in November), which appears to break `vessel verify` as mentioned in [this forum topic](https://forum.dfinity.org/t/heartbeat-improvements-timers-community-consideration/14201/94) and indicated by [this PR's CI output](https://github.com/dfinity/vessel-package-set/actions/runs/3797230768/jobs/6457979836). This also appears to affect `moc 0.7.4`, so we should definitely find a way to automatically screen for future regressions like this. Co-authored-by: Ryan Vandersmith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a reference to
"mo:base/Debug"inTrie.mo(originating from a PR in November), which appears to breakvessel verifyas mentioned in this forum topic and indicated by this PR's CI output.This also appears to affect
moc 0.7.4, so we should definitely find a way to automatically screen for future regressions like this.This is botched merge #487, again.