Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible improvements for Int8/16/32/64 #476

Open
luc-blaeser opened this issue Dec 21, 2022 · 0 comments
Open

Possible improvements for Int8/16/32/64 #476

luc-blaeser opened this issue Dec 21, 2022 · 0 comments
Labels
breaking-change Changes public API, and requires clients fix their usage.

Comments

@luc-blaeser
Copy link
Contributor

luc-blaeser commented Dec 21, 2022 •
edited
Loading

Possible improvements for Int8.mo, Int16.mo, Int32.mo, and Int64:

  • Support matchers with Int8/16/32/64/Nat8/16/32/64/Float/Order Testable.
  • Inconsistent naming of functions, e.g. bitrotLeft() (instead of bitRotLeft()).
  • Inconsistent type of second argument in bit operations: bitshiftLeft() uses Int64 but bittest() uses Nat.

Already fixed by PR #478:

  • Minimum value and maximum value constants are missing.
  • bitnot() has a superfluous second argument: bitnot(x, y) should be bitnot(x).
@luc-blaeser luc-blaeser mentioned this issue Dec 22, 2022
Merged
@luc-blaeser luc-blaeser added the breaking-change Changes public API, and requires clients fix their usage. label Dec 22, 2022
@luc-blaeser luc-blaeser mentioned this issue Jan 5, 2023
Merged
luc-blaeser added a commit that referenced this issue Jan 5, 2023
@luc-blaeser
Fix: Base library issues in Int8/16/32/64 (#478)
885067b 
Fix some issues reported in #476:
* Offer minimum and maximum integer constants
* Remove superfluous second argument in `bitnot()`
luc-blaeser added a commit that referenced this issue Jan 5, 2023
@luc-blaeser
Int8/16/32/64 documentation and unit tests (#475)
4f8d37b 
Improve `Int8.mo`, `Int16.mo`, `Int32.mo`, and `Int64.mo`:
* Documentation
* Unit tests
* Related to: #473

Possible improvements for Int8/16/32/64 (#476):
* Minimum value and maximum value constants are missing.
* `bitnot()` has a superfluous second argument: `bitnot(x, y)` should be `bitnot(x)`.
* Inconsistent naming of functions, e.g. `bitrotLeft` (instead of `bitRotLeft`).
* Inconsistent type of second argument in bit operations: `bitshiftLeft` uses `Int64` but  `bittest` uses `Nat`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Changes public API, and requires clients fix their usage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luc-blaeser