Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Base library issues in Int8/16/32/64 #478

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Fix: Base library issues in Int8/16/32/64 #478

merged 5 commits into from
Jan 5, 2023

Conversation

luc-blaeser
Copy link
Contributor

Fix some most obvious issues reported in #476:

  • Offer minimum and maximum integer constants
  • Remove superfluous second argument in bitnot()

@luc-blaeser luc-blaeser changed the base branch from master to luc/improve-int-8-16-32-64-tests-doc December 22, 2022 10:32
@luc-blaeser luc-blaeser self-assigned this Dec 22, 2022
@luc-blaeser luc-blaeser marked this pull request as ready for review December 22, 2022 10:50
@luc-blaeser luc-blaeser added the breaking-change Changes public API, and requires clients fix their usage. label Dec 22, 2022
@luc-blaeser luc-blaeser changed the title Fix: Some obvious issues in Int8/16/32/64 Fix: Base library issues in Int8/16/32/64 Dec 22, 2022
crusso
crusso approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we want similar for Nat8 - Nat64?

This is a breaking change because of the bitnot change but hopefully it won't affect many.

@luc-blaeser
Copy link
Contributor Author

LGTM. I guess we want similar for Nat8 - Nat64?

This is a breaking change because of the bitnot change but hopefully it won't affect many.

Thanks a lot. Indeed, the analogous would be helpful for Nat8 - Nat64 too.
I assume it is okay to have a breaking change (to remove the superfluous argument on bitnot())?

@luc-blaeser luc-blaeser merged commit 885067b into luc/improve-int-8-16-32-64-tests-doc Jan 5, 2023
@luc-blaeser luc-blaeser deleted the luc/fix-int8-16-32-64 branch January 5, 2023 10:40
This was referenced Jan 5, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

@ggreif ggreif Awaiting requested review from ggreif

Assignees

@luc-blaeser luc-blaeser

Labels
breaking-change Changes public API, and requires clients fix their usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luc-blaeser @crusso