fix(export): Escape MySQL column names #8947
Conversation
|
|
|
Thanks for updating the PR. Please create the PR against the |
mangalaman93
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
|
@andres-lowrie thanks for signing the CLA. The linter is not happy, could you take a look? Happy to help if it is not straight forward for you to figure out. |
|
@andres-lowrie Thanks for the PR - I think this PR needs to be rebased (or recreated) against our main branch. Check that you have our latest main and that this PR is branched off from there. I see that the base branch was changed from master to main but the original commits were presumably against master. This should resolve the CI issues. I would do this myself but since this is on your fork it is not possible for me to do. |
|
Maybe the linter issue is also because this PR does not have latest main. |
Correct - the jobs that are running (and failing) are coming from workflow files checked into the old master branch. The jobs marked as required are coming from our PR merge requirements on github. Hence the confusion in CI. They are not running because the workflow files are presumably not in the the branch Fortunately this PR has a relatively small surface area, so in the worst case @andres-lowrie can recreate it relatively easily (from our main branch). |
|
oops yeah I think I get it now. I'll re-do the changes from |
|
let me close this one out |
|
created other pr #8961 |
Description: This change wraps all the column names with backticks so that MySQL won't complain when a table has columns that are also reserved keywords in MySQL.